Skip to content

Commit a191df4

Browse files
committed
Don't include own IP into call-id: it serves no practical purpose
and can lead to the information leak.
1 parent 207bf8e commit a191df4

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

sippy/SipCallId.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -52,15 +52,14 @@ def __init__(self, body = None):
5252
SipGenericHF.__init__(self, body)
5353
self.parsed = True
5454
if body is None:
55-
salt = str((random() * 1000000000) + time())
56-
self.body = md5(salt.encode()).hexdigest() + '@' + str(SipConf.my_address)
55+
self.genCallId()
5756

5857
def __add__(self, other):
5958
return SipCallId(self.body + str(other))
6059

6160
def genCallId(self):
6261
salt = str((random() * 1000000000) + time())
63-
self.body = md5(salt.encode()).hexdigest() + '@' + str(SipConf.my_address)
62+
self.body = md5(salt.encode()).hexdigest()
6463

6564
def getCanName(self, name, compact = False):
6665
if compact:

0 commit comments

Comments
 (0)