Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnnotationOverlayImpl#annotation does not detect Object properly when searching for inherited annotations #497

Closed
manovotn opened this issue Feb 13, 2025 · 0 comments · Fixed by #498
Closed

AnnotationOverlayImpl#annotation does not detect Object properly when searching for inherited annotations #497

manovotn opened this issue Feb 13, 2025 · 0 comments · Fixed by #498
Milestone
3.2.7

Comments

@manovotn
Copy link
Contributor

I originally encountered this with Quarkus and CDI BCE extensions observing Object type, not sure how common it would be otherwise.

The code in AnnotationOverlayImpl#annotation attempts to search for inherited annotations in super classes of given Declaration even if it is already Object type. This can lead to unexpected calls to IndexView#getClassByName() with null as parameter.

The code I am describing is here - https://github.com/smallrye/jandex/blob/main/core/src/main/java/org/jboss/jandex/AnnotationOverlayImpl.java#L135

I'll send a PR momentarily.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.7
Development

Successfully merging a pull request may close this issue.

Fix detection of Object type in AnnotationOverlayImpl#annotation manovotn/jandex
2 participants
@Ladicek @manovotn