Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-utilities] AAA unit tests do not handle mock DB connection correctly #21871

Open
anders-nexthop opened this issue Feb 26, 2025 · 0 comments
Assignees
Labels
Triaged this issue has been triaged

Comments

@anders-nexthop
Copy link

Many test cases in sonic-utilities/tests/aaa_test.py and sonic-utilities/tests/radius_test.py are handling mock database connections incorrectly. The state configured by AAA config commands is not the same state used by the AAA show commands that are being used as validation. Instead, desired state is manually fed into AAA show commands to produce the desired results. This is a clear break from the prevalent pattern in sonic-utilities/tests in which config commands are verified with their accompanying show commands.

This is a duplicate of sonic-net/sonic-utilities/issues/3754 which I am raising here to get better visibility. Please see that issue for further details.

A fix is proposed here.

@arlakshm arlakshm added the Triaged this issue has been triaged label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triaged this issue has been triaged
Projects
None yet
Development

No branches or pull requests

2 participants