Merge pull request alleyinteractive#428 from alleyinteractive/enrico-sorcinelli-datasource-user

Add wildcards to get_users search

Author: mboynes

php/datasource/class-fieldmanager-datasource-user.php

@@ -141,7 +141,7 @@ public function get_items( $fragment = Null ) {
         $ret = array();
 
         if ( $fragment ) {
-        	$user_args['search'] = $fragment;
+        	$user_args['search'] = '*' . $fragment . '*';
         }
 
         $users = get_users( $user_args );

tests/php/test-fieldmanager-datasource-user.php

@@ -12,7 +12,7 @@ public function setUp() {
 		parent::setUp();
 		Fieldmanager_Field::$debug = true;
 
-		$this->author = $this->factory->user->create( array( 'role' => 'author', 'user_login' => 'author', 'user_email' => '[email protected]' ) );
+		$this->author = $this->factory->user->create( array( 'role' => 'author', 'user_login' => 'author', 'user_email' => '[email protected]', 'display_name' => 'Lorem Ipsum' ) );
 		$this->editor = $this->factory->user->create( array( 'role' => 'editor', 'user_login' => 'editor' ) );
 		$this->administrator = $this->factory->user->create( array( 'role' => 'administrator', 'user_login' => 'administrator' ) );
 
@@ -273,4 +273,30 @@ public function test_store_property_display() {
 		$this->assertEquals( $user->display_name, $test_users_user_nicename[ $user->user_nicename ] );
 		$this->assertEquals( $user->display_name, $test_user_nicename->datasource->get_value( $user->user_nicename ) );
 	}
+
+	public function test_search() {
+		$user = get_userdata( $this->author );
+		$display_name = 'Lorem Ipsum';
+
+		$fm = new Fieldmanager_Autocomplete( array(
+			'name' => 'test_search',
+			'datasource' => new Fieldmanager_Datasource_User
+		) );
+
+		$test_users_id = $fm->datasource->get_items( $display_name );
+		$this->assertEquals( $display_name, $test_users_id[ $user->ID ] );
+		$this->assertEquals( $display_name, $fm->datasource->get_value( $user->ID ) );
+
+		$test_users_id = $fm->datasource->get_items( 'rem' );
+		$this->assertEquals( $display_name, $test_users_id[ $user->ID ] );
+
+		$test_users_id = $fm->datasource->get_items( '[email protected]' );
+		$this->assertEquals( $display_name, $test_users_id[ $user->ID ] );
+
+		$test_users_id = $fm->datasource->get_items( 'author' );
+		$this->assertEquals( $display_name, $test_users_id[ $user->ID ] );
+
+		$test_users_id = $fm->datasource->get_items( $user->ID );
+		$this->assertEquals( $display_name, $test_users_id[ $user->ID ] );
+	}
 }