Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshots are not publishing javadoc and source jars correctly #1173

Closed
wilkinsona opened this issue Apr 18, 2023 · 2 comments
Closed

Snapshots are not publishing javadoc and source jars correctly #1173

wilkinsona opened this issue Apr 18, 2023 · 2 comments
Assignees
Labels
status: duplicate A duplicate of another issue

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Apr 18, 2023

spring-security-oauth2-authorization-server-1.1.0-20230418.123134-91-javadoc.jar        18-04-23 16:57:47 +0100    804.8 KB
spring-security-oauth2-authorization-server-1.1.0-20230418.123134-91-javadoc.jar.asc    18-04-23 16:57:47 +0100    821.0 B
spring-security-oauth2-authorization-server-1.1.0-20230418.123134-91-sources.jar        18-04-23 16:57:48 +0100    332.6 KB
spring-security-oauth2-authorization-server-1.1.0-20230418.123134-91-sources.jar.asc    18-04-23 16:57:48 +0100    821.0 B
spring-security-oauth2-authorization-server-1.1.0-20230418.123134-91.jar                18-04-23 13:31:34 +0100    486.5 KB
spring-security-oauth2-authorization-server-1.1.0-20230418.123134-91.jar.asc            18-04-23 13:31:34 +0100    821.0 B
spring-security-oauth2-authorization-server-1.1.0-20230418.123134-91.module             18-04-23 13:31:34 +0100      7.0 KB
spring-security-oauth2-authorization-server-1.1.0-20230418.123134-91.module.asc         18-04-23 13:31:35 +0100    821.0 B
spring-security-oauth2-authorization-server-1.1.0-20230418.123134-91.pom                18-04-23 13:31:35 +0100      4.0 KB
spring-security-oauth2-authorization-server-1.1.0-20230418.123134-91.pom.asc            18-04-23 13:31:35 +0100    821.0 B
spring-security-oauth2-authorization-server-1.1.0-20230418.155749-92.jar                18-04-23 16:57:49 +0100    486.5 KB
spring-security-oauth2-authorization-server-1.1.0-20230418.155749-92.jar.asc            18-04-23 16:57:49 +0100    821.0 B
spring-security-oauth2-authorization-server-1.1.0-20230418.155749-92.module             18-04-23 16:57:49 +0100      7.0 KB
spring-security-oauth2-authorization-server-1.1.0-20230418.155749-92.module.asc         18-04-23 16:57:50 +0100    821.0 B
spring-security-oauth2-authorization-server-1.1.0-20230418.155749-92.pom                18-04-23 16:57:50 +0100    4.0 KB
spring-security-oauth2-authorization-server-1.1.0-20230418.155749-92.pom.asc            18-04-23 16:57:50 +0100    821.0 B

Note the lack of -source and -javadoc artifacts for build 92. Judging by the timestamps, deploying build 92 has overwritten the jars for build 91. We have seen this before with Spring Security although it was several years ago. Perhaps the fix that was applied there is relevant here as well?

@wilkinsona wilkinsona added the type: bug A general bug label Apr 18, 2023
@jgrandja
Copy link
Collaborator

Thanks @wilkinsona. I'll look into this.

@jgrandja jgrandja moved this to In Progress in Spring Security Team Apr 19, 2023
@jgrandja jgrandja self-assigned this Apr 19, 2023
@jgrandja
Copy link
Collaborator

@wilkinsona This is now fixed via gh-1179 with the valuable help of @jvalkeal.

The latest snapshot build for 0.4.x, 1.0.x and main have the sources and javadoc. But keep in mind the older snapshot builds are as-is so if this causes any further issues we can simply remove them. Just let me know.

Closing this as a duplicate of gh-1179.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Spring Security Team Apr 19, 2023
@jgrandja jgrandja added status: duplicate A duplicate of another issue and removed type: bug A general bug labels Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
Status: Done
Development

No branches or pull requests

2 participants