New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eval() mode for eval_one_epoch()? #9

Open

soldierofhell opened this issue Oct 14, 2019 · 1 comment

soldierofhell commented Oct 14, 2019 •

edited

Loading

Hi @sshaoshuai,
Shouldn't evaluation be performed in eval() mode?
https://github.com/sshaoshuai/Pointnet2.PyTorch/blob/master/tools/train_and_eval.py#L103

The text was updated successfully, but these errors were encountered:

Author

soldierofhell commented Oct 14, 2019 •

edited

Loading

Also 'model' call should be preceded with torch.no_grad() context

Edit: Ok, I found this is done before eval_one_epoch
https://github.com/sshaoshuai/Pointnet2.PyTorch/blob/master/tools/train_and_eval.py#L176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment