Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement One Trait Analogous to Rust's in Cairo #3881

Closed
neotheprogramist opened this issue Aug 11, 2023 · 1 comment
Closed

feat: Implement One Trait Analogous to Rust's in Cairo #3881

neotheprogramist opened this issue Aug 11, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@neotheprogramist
Copy link
Contributor

Feature Proposal

Considering our existing implementation of the Zeroable trait, it would be beneficial to add an analogous One trait to our Cairo compiler.

Background

In Rust, there exists a One trait that serves a similar purpose for the multiplicative identity. An analogous trait in Cairo would enrich our library and provide consistent utility alongside the Zeroable trait.

Desired Behavior

The task is to design and implement a One trait in the Cairo compiler that aligns with the concept of Rust's One trait. This should include the essential functions and features to make it as effective as the Rust version.

@orizi
Copy link
Collaborator

orizi commented Nov 21, 2023

Fixed by #4254 - thanks @enitrat

@orizi orizi closed this as completed Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants