Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: deploy_syscall behavior in testing context #5361

Closed
notV4l opened this issue Apr 5, 2024 · 0 comments · Fixed by #5365
Closed

bug: deploy_syscall behavior in testing context #5361

notV4l opened this issue Apr 5, 2024 · 0 comments · Fixed by #5365
Labels
bug Something isn't working

Comments

@notV4l
Copy link
Contributor

notV4l commented Apr 5, 2024

Bug Report

Cairo version:
Latest

Current behavior:
In testing context, deploy_syscall doesn't test if a contract is already deployed at address.
Is this intended behavior ?

Expected behavior:
I'd expect a fail_syscall!(b"CONTRACT_ALREADY_DEPLOYED");

Related code:

/// Executes the `deploy_syscall` syscall.
fn deploy(
&mut self,
gas_counter: &mut usize,
class_hash: Felt252,
_contract_address_salt: Felt252,
calldata: Vec<Felt252>,
deploy_from_zero: bool,
vm: &mut dyn VMWrapper,
) -> Result<SyscallResult, HintError> {

@notV4l notV4l added the bug Something isn't working label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant