Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Associate Cairo logo with .cairo files in VS Code file explorer and file editor #5626

Closed
0xNeshi opened this issue May 23, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@0xNeshi
Copy link

0xNeshi commented May 23, 2024

Due to missing Logo for the official Cairo 1.0 VS Code extension and the associated .cairo files, my first impression when using the extension was that I downloaded a custom one made by some 3rd party instead of the official one made by StarkWare.

Displaying the official Cairo language logo next to .cairo files would make it clear that these are valid Cairo files.
This would also make the whole VS Code extension look more professional and genuine.

  • file explorer:

    • current:
      image
    • with icon:
      image
  • file editor:

    • current:
      image
    • with icon:
      image
@0xNeshi 0xNeshi added the enhancement New feature or request label May 23, 2024
@mkaput mkaput added the ide label May 23, 2024
@github-project-automation github-project-automation bot moved this to Triage in CairoLS May 23, 2024
@mkaput mkaput added the good first issue Good for newcomers label May 23, 2024
@mkaput mkaput moved this from Triage to Backlog in CairoLS May 23, 2024
@Utilitycoder
Copy link
Contributor

I would like to work on this issue and contribute the necessary changes.

Could you please assign this issue to me and provide pointers on which files need to be updated to implement this change?

@mkaput
Copy link
Member

mkaput commented May 24, 2024

The task is yours. I have no idea what has to be changed of if it's actually possible (because VSCode has a concept of icon themes) 🙃

Thanks ❤️

@Utilitycoder
Copy link
Contributor

I have figured out the solution to the issue. I however need a transparent icon that should be used. I think there will be an official brand guide so I don't want to use just anything on the internet.
Screenshot 2024-05-26 at 19 03 39

@0xNeshi
Copy link
Author

0xNeshi commented May 27, 2024

@Utilitycoder here's a Cairo logo with transparent background
Cairo-logo

@mkaput
Copy link
Member

mkaput commented May 27, 2024

Thanks @misicnenad for providing it. @Utilitycoder if you'll find descaling this giving bad quality, I can ask Starkware marketing ppl for an SVG version.

@mkaput mkaput moved this from Backlog to Done in CairoLS May 27, 2024
@mkaput mkaput moved this from Done to Todo in CairoLS May 27, 2024
@mkaput mkaput moved this from Todo to In Progress in CairoLS May 27, 2024
@enitrat
Copy link
Contributor

enitrat commented May 28, 2024

https://starkware.co/media-kit/ the branding kit is publicly available here

@mkaput mkaput closed this as completed May 29, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in CairoLS May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
No open projects
Archived in project
Development

No branches or pull requests

4 participants