Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Wrongly mapped diagnostics in LS #6394

Closed
Arcticae opened this issue Sep 20, 2024 · 1 comment · Fixed by #6446
Closed

bug: Wrongly mapped diagnostics in LS #6394

Arcticae opened this issue Sep 20, 2024 · 1 comment · Fixed by #6446
Assignees
Labels
bug Something isn't working

Comments

@Arcticae
Copy link
Collaborator

The diagnostics are being refreshed for VFS files again, which leads to wrongly mapping them to VFS files instead of user code

Example:

image

@Arcticae Arcticae added bug Something isn't working ide labels Sep 20, 2024
@Arcticae Arcticae self-assigned this Sep 20, 2024
@github-project-automation github-project-automation bot moved this to Triage in CairoLS Sep 20, 2024
@orizi
Copy link
Collaborator

orizi commented Sep 23, 2024

I would not consider it Wrongly mapped - it is just also mapped for the VFS file.

we can rather easily make it actually point to the error within the generated file if it was opened (by stopping the remapping upon getting to the generated file)

@Arcticae Arcticae linked a pull request Oct 1, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in CairoLS Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants