Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-backgrounds: Simplified parameters API #10572

Closed
4 tasks
shilman opened this issue Apr 28, 2020 · 1 comment
Closed
4 tasks

Addon-backgrounds: Simplified parameters API #10572

shilman opened this issue Apr 28, 2020 · 1 comment
Assignees
Labels
Milestone

Comments

@shilman
Copy link
Member

shilman commented Apr 28, 2020

See discussion here #9164

// preview.js
addParameters({
  backgrounds: {
    default: 'white',
    values: [
      { name: 'white', value: '#ffffff' }, 
      { name: 'black', value: '#000000' },
    ]
  }
}

// Foo.stories.js
export const Foo = ...
Foo.story = {
  parameters: {
    backgrounds: { default: 'black' },
  }
}

Needed:

  • Upgraded API
  • Deprecate old API (or remove completely)
  • Update documentation
  • Update MIGRATION.md
@shilman
Copy link
Member Author

shilman commented May 7, 2020

Yippee!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-beta.3 containing PR #10634 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants