Single source of truth for platform auth type. (#5320)

Author: michelinewu

app/components-react/pages/PlatformMerge.tsx

@@ -1,7 +1,12 @@
 import React, { useState } from 'react';
 import { EAuthProcessState } from 'services/user';
 import { $t } from 'services/i18n';
-import { EPlatformCallResult, getPlatformService, TPlatform } from '../../services/platforms';
+import {
+  EPlatformCallResult,
+  externalAuthPlatforms,
+  getPlatformService,
+  TPlatform,
+} from '../../services/platforms';
 import { Services } from 'components-react/service-provider';
 import { useVuex } from 'components-react/hooks';
 import { alertAsync } from 'components-react/modals';
@@ -38,9 +43,7 @@ export default function PlatformMerge(p: IPlatformMergeProps) {
 
   async function mergePlatform() {
     if (!platform) return;
-    const mode = ['youtube', 'twitch', 'twitter', 'tiktok', 'kick'].includes(platform)
-      ? 'external'
-      : 'internal';
+    const mode = externalAuthPlatforms.includes(platform) ? 'external' : 'internal';
     await UserService.actions.return
       .startAuth(platform, mode, true)
       .then(res => {

app/components-react/pages/onboarding/Connect.tsx

@@ -5,7 +5,13 @@ import { $t } from 'services/i18n';
 import { Services } from 'components-react/service-provider';
 import { injectState, useModule, mutation } from 'slap';
 import { ExtraPlatformConnect } from './ExtraPlatformConnect';
-import { EPlatform, EPlatformCallResult, TPlatform, platformLabels } from 'services/platforms';
+import {
+  EPlatform,
+  EPlatformCallResult,
+  TPlatform,
+  externalAuthPlatforms,
+  platformLabels,
+} from 'services/platforms';
 import * as remote from '@electron/remote';
 import { OnboardingModule } from './Onboarding';
 import { EAuthProcessState } from 'services/user';
@@ -265,9 +271,7 @@ export class LoginModule {
 
     const result = await this.UserService.startAuth(
       platform,
-      ['youtube', 'twitch', 'twitter', 'tiktok', 'kick'].includes(platform)
-        ? 'external'
-        : 'internal',
+      externalAuthPlatforms.includes(platform) ? 'external' : 'internal',
       merge,
     );
 

app/components-react/windows/settings/Stream.tsx

@@ -2,7 +2,12 @@ import React, { useMemo, useState } from 'react';
 import { $t } from '../../../services/i18n';
 import { ICustomStreamDestination } from '../../../services/settings/streaming';
 import { EStreamingState } from '../../../services/streaming';
-import { EPlatformCallResult, getPlatformService, TPlatform } from '../../../services/platforms';
+import {
+  EPlatformCallResult,
+  externalAuthPlatforms,
+  getPlatformService,
+  TPlatform,
+} from '../../../services/platforms';
 import cloneDeep from 'lodash/cloneDeep';
 import namingHelpers from '../../../util/NamingHelpers';
 import { Services } from '../../service-provider';
@@ -217,9 +222,7 @@ class StreamSettingsModule {
   }
 
   async platformMergeInline(platform: TPlatform) {
-    const mode = ['youtube', 'twitch', 'twitter', 'tiktok', 'kick'].includes(platform)
-      ? 'external'
-      : 'internal';
+    const mode = externalAuthPlatforms.includes(platform) ? 'external' : 'internal';
 
     await Services.UserService.actions.return.startAuth(platform, mode, true).then(res => {
       Services.WindowsService.actions.setWindowOnTop('child');

app/services/platforms/index.ts

@@ -302,3 +302,5 @@ export function getPlatformService(platform: TPlatform): IPlatformService {
 export interface IPlatformRequest extends RequestInit {
   url: string;
 }
+
+export const externalAuthPlatforms = ['youtube', 'twitch', 'twitter', 'tiktok', 'kick'];