Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't save user with empty study entry #1152

Open
hanna-m1 opened this issue Jan 7, 2025 · 2 comments
Open

Can't save user with empty study entry #1152

hanna-m1 opened this issue Jan 7, 2025 · 2 comments
Labels
enhancement Proposes (changes to) a feature good first issue

Comments

@hanna-m1
Copy link

hanna-m1 commented Jan 7, 2025

Expected behaviour

When creating a begunstiger, I give the label begunstiger and do not add a study (because they do not follow a Sticky study)

Actual behavior

When I add the label begunstiger and save the person, it gives an error that I need to enter a study and starting date.

It works when I first give them a study, then save, then edit and remove the study and add the tag and then save it.

Steps to reproduce

  • admin
    Screenshot 2025-01-07 143535

  • browser:

@SilasPeters SilasPeters added the bug label Jan 7, 2025
@SpookyBoy99
Copy link
Contributor

This is not a bug, but weird behavior from Koala. By default Koala adds an empty study entry in the edit view if none exist - this is both when creating a new user or updating a user that has no studies associated with them (like a begunstiger). In order to create a user or save the changes, one must first delete the empty study by clicking the bin icon. I do agree that this behavior is undesirable and must be changed, so I propose the following:

  • Change the title to: Can't save users with empty study entries
  • Update the label to 'enhancement' rather than 'bug'
  • Change this behavior to one of the options below

Option 1

Do not automatically add a new empty study entry for new users or users without studies associated with them.

Option 2

Allow empty entries for the study field.

Option 2a

If one allows empty study entries, I would still suggested to update the user edit page so that no new empty studies will be added to existing users, but keep this functionality for new users.

@SilasPeters
Copy link
Member

I would go with option 1. This is way more intuitive.

@SilasPeters SilasPeters changed the title Begunstiger label gives error without study Can't save user with empty study entry Jan 17, 2025
@SilasPeters SilasPeters added enhancement Proposes (changes to) a feature good first issue and removed bug labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Proposes (changes to) a feature good first issue
Projects
None yet
Development

No branches or pull requests

3 participants