Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: Autocomplete / Typeahead | Positive #1965

Closed
wueestd opened this issue Sep 19, 2023 · 8 comments
Closed

Component: Autocomplete / Typeahead | Positive #1965

wueestd opened this issue Sep 19, 2023 · 8 comments
Assignees
@Cian77
Milestone
Design V1

Comments

@wueestd
Copy link

wueestd commented Sep 19, 2023 •
edited by Cian77
Loading

Figma:
https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=16691%3A55893&mode=design&t=UTRU4FvIZ6ZvFBGz-1

Story book:
No component

Comments:

  • Reworked Design
  • Added documentation

Examples

Image

https://www.post.ch/de

Dev
https://design-system.post.ch/#/ng-bootstrap-samples/typeahead

Doc
https://www.experience-hub.ch/document/2803#/organisms-module/menus:67855
@wueestd wueestd converted this from a draft issue Sep 19, 2023
@wueestd wueestd mentioned this issue Sep 19, 2023
Closed
@wueestd wueestd added this to the Design V1 milestone Sep 27, 2023
@wueestd wueestd changed the title Component: Autocomplete Component: Autocomplete / Typeahead Sep 27, 2023
@wueestd wueestd moved this from 📋 Backlog to 🔖 Ready in Design System Production Board Oct 25, 2023
@wueestd wueestd self-assigned this Oct 25, 2023
@wueestd wueestd moved this from 🔖 Ready to 🏗 In progress in Design System Production Board Oct 25, 2023
@wueestd
Copy link
Author

wueestd commented Nov 1, 2023

@kaloyanso can you have a look at the setup please?

@wueestd wueestd assigned rouvenpost and wueestd and unassigned wueestd and kaloyanso Nov 6, 2023
@rouvenpost
Copy link

@wueestd look good. Only thing is the "fill to Search field" function. Not shure if the users understand this. Maybe use the Plus Icon?

@rouvenpost rouvenpost removed their assignment Nov 7, 2023
@wueestd wueestd moved this from 🏗 In progress to 👀 In review in Design System Production Board Nov 15, 2023
@wueestd wueestd assigned Cian77 and kaloyanso and unassigned wueestd Nov 15, 2023
@wueestd
Copy link
Author

wueestd commented Nov 15, 2023

@Cian77 / @kaloyanso could any of you review the component and the documentation please?

@wueestd wueestd assigned wueestd and unassigned Cian77 and kaloyanso Nov 21, 2023
@wueestd
Copy link
Author

wueestd commented Nov 21, 2023

ready for dev review @gfellerph

@wueestd wueestd assigned gfellerph and unassigned wueestd Nov 21, 2023
@gfellerph
Copy link
Member

  • Discuss naming, it's a component intended for composition and "Autocomplete" is usually a complete component
  • Resolve comments in Dos and Don'ts

@wueestd
Copy link
Author

wueestd commented Nov 29, 2023

I have added some comments @gfellerph

@wueestd wueestd removed their assignment Nov 29, 2023
@gfellerph
Copy link
Member

@Cian77 needs a rework after the decision around border radius 0.

@gfellerph gfellerph assigned Cian77 and unassigned gfellerph Jan 8, 2024
@Cian77 Cian77 moved this from 👀 In review to 🏗 In progress in Design System Production Board Jan 9, 2024
@Cian77 Cian77 moved this from 🏗 In progress to 👀 In review in Design System Production Board Jan 18, 2024
@Cian77 Cian77 changed the title Component: Autocomplete / Typeahead Component: Autocomplete / Typeahead | Positive Feb 1, 2024
@github-actions github-actions bot added the stale This issue has not seen any activity in 90 days and should be re-evaluated. label May 1, 2024
@gfellerph gfellerph removed the stale This issue has not seen any activity in 90 days and should be re-evaluated. label May 27, 2024
@gfellerph
Copy link
Member

Closing in favour of v2

@github-project-automation github-project-automation bot moved this from 😍 Design in review to 🚀 Done in Design System Production Board Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cian77 Cian77

Labels
None yet
Projects
Design System Production Board
Archived in project
Milestone
Design V1
Development

No branches or pull requests
5 participants
@gfellerph @wueestd @rouvenpost @Cian77 @kaloyanso