Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix used lifecycle hook for initial component property checks #3153

Closed
1 of 3 tasks
Tracked by #3687
oliverschuerch opened this issue Jun 13, 2024 · 0 comments · Fixed by #3775
Closed
1 of 3 tasks
Tracked by #3687

Fix used lifecycle hook for initial component property checks #3153

oliverschuerch opened this issue Jun 13, 2024 · 0 comments · Fixed by #3775
Assignees
Labels
🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package request This is a request from a contributor outside of the core team. v8

Comments

@oliverschuerch
Copy link
Contributor

oliverschuerch commented Jun 13, 2024

post-icon and other components throw an error, even when a required property is set.
image

Tasks

Preview Give feedback
  1. v8

We can see the same error also in our documentation e2e tests:
Image

Use these to test if the fix works.

@oliverschuerch oliverschuerch added 🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package request This is a request from a contributor outside of the core team. labels Jun 13, 2024
@oliverschuerch oliverschuerch added this to the Web Components milestone Jun 13, 2024
@github-project-automation github-project-automation bot moved this to 🗃️ Ready for work in Design System Production Board Jun 13, 2024
@gfellerph gfellerph removed this from the Web Components milestone Jul 15, 2024
@gfellerph gfellerph moved this from 🗃️ Ready for design to 💻 Ready for development in Design System Production Board Sep 25, 2024
@gfellerph gfellerph added the v8 label Oct 3, 2024
@gfellerph gfellerph added this to the Long Term Support milestone Oct 14, 2024
@gfellerph gfellerph self-assigned this Oct 16, 2024
@gfellerph gfellerph linked a pull request Oct 16, 2024 that will close this issue
@gfellerph gfellerph moved this from 💻 Ready for development to 🤬 Dev in review in Design System Production Board Oct 16, 2024
@github-project-automation github-project-automation bot moved this from 🤬 Dev in review to 🚀 Done in Design System Production Board Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package request This is a request from a contributor outside of the core team. v8
Projects
Development

Successfully merging a pull request may close this issue.

3 participants