Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate tooltip lighthouse error #3600

Closed
2 tasks
alizedebray opened this issue Sep 30, 2024 · 2 comments · Fixed by #3619
Closed
2 tasks

Investigate tooltip lighthouse error #3600

alizedebray opened this issue Sep 30, 2024 · 2 comments · Fixed by #3619
Assignees
@schaertim
Labels
🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package request

Comments

@alizedebray
Copy link
Contributor

alizedebray commented Sep 30, 2024 •
edited by gfellerph
Loading

Lighthouse is giving an "ARIA tooltip nodes must have an accessible name" error for the post-tooltip:
https://dequeuniversity.com/rules/axe/4.9/aria-tooltip-name

Tasks
Preview Give feedback
@alizedebray alizedebray added 🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package labels Sep 30, 2024
@gfellerph gfellerph moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Oct 2, 2024
@gfellerph
Copy link
Member

Might be a solution to move the role=tooltip declaration to the <post-popovercontainer> instead, because that one is hidden and shown.

@schaertim schaertim self-assigned this Oct 2, 2024
@schaertim schaertim linked a pull request Oct 2, 2024 that will close this issue
fix(components): fixed accessibility issue with tooltips #3619
Merged
@schaertim schaertim added the needs: 🏓 dev roundtable To be discussed at the roundtable of esteemed developers label Oct 15, 2024
@gfellerph
Copy link
Member

Check if we can implement <post-popovercontainer> to be visually hidden only (for tooltip, not for popover).

@schaertim schaertim removed the needs: 🏓 dev roundtable To be discussed at the roundtable of esteemed developers label Oct 24, 2024
@github-project-automation github-project-automation bot moved this from 🤬 Dev in review to 🚀 Done in Design System Production Board Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schaertim schaertim

Labels
🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package request
Projects
Design System Production Board
Status: 🚀 Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(components): fixed accessibility issue with tooltips swisspost/design-system
3 participants
@gfellerph @alizedebray @schaertim