Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local header padding #4860

Open
alizedebray opened this issue Mar 3, 2025 · 1 comment
Open

Local header padding #4860

alizedebray opened this issue Mar 3, 2025 · 1 comment
Assignees
@alizedebray @alionazherdetska
Labels
📦 components Related to the @swisspost/design-system-components package Header Everything related to our composible header components
Milestone
PPNL Support

Comments

@alizedebray
Copy link
Contributor

The local header padding is different whether the title wraps or not.
In the currently released version the local header therefore has an incorrect height on mobile and tablet due to this padding.

This unexpected height is causing a layout shift.

https://www.figma.com/design/JIT5AdGYqv6bDRpfBPV8XR?node-id=11565-26175&m=dev#1156166949
@alizedebray alizedebray added Header Everything related to our composible header components needs: 💬 pattern discussion This issue will be discussed in the next Pattern Discussion meeting. labels Mar 3, 2025
This was referenced Mar 3, 2025
Open
Draft
@alizedebray alizedebray added the 📦 components Related to the @swisspost/design-system-components package label Mar 3, 2025
@alizedebray
Copy link
Contributor Author

Resolution: use padding defined for a one-line title in Figma.

@alizedebray alizedebray removed the needs: 💬 pattern discussion This issue will be discussed in the next Pattern Discussion meeting. label Mar 4, 2025
@gfellerph gfellerph added this to the PPNL Support milestone Mar 5, 2025
@gfellerph gfellerph moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Mar 5, 2025
@alionazherdetska alionazherdetska self-assigned this Mar 5, 2025
@alizedebray alizedebray self-assigned this Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alizedebray alizedebray

@alionazherdetska alionazherdetska

Labels
📦 components Related to the @swisspost/design-system-components package Header Everything related to our composible header components
Projects
Design System Production Board
Status: 💻 Ready for development
Milestone
PPNL Support
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/4860-local-header-padding swisspost/design-system
3 participants
@gfellerph @alizedebray @alionazherdetska