Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.8] Ability to inject security.access.decision_manager into voters #5306

Closed
weaverryan opened this issue May 23, 2015 · 1 comment
Closed

[2.8] Ability to inject security.access.decision_manager into voters #5306

weaverryan opened this issue May 23, 2015 · 1 comment
Labels
good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue. Security
Milestone
2.8

Comments

@weaverryan
Copy link
Member

See symfony/symfony#14733. The security.access.decision_manager can now be injected into voters, so we can document in the cookbook about custom voters how you could, for example, call isGranted('ROLE_ADMIN') from inside a custom voter without needing to do something like inject the container.
@weaverryan weaverryan added this to the 2.8 milestone May 23, 2015
@weaverryan weaverryan mentioned this issue May 23, 2015
Merged
@xabbuh xabbuh added the On hold label May 23, 2015
@weaverryan weaverryan added good first issue Ideal for your first contribution! (some Symfony experience may be required) actionable Clear and specific issues ready for anyone to take them. and removed On hold labels Jun 1, 2015
@weaverryan weaverryan changed the title [2.8][WCM] Ability to inject security.access.decision_manager into voters [2.8] Ability to inject security.access.decision_manager into voters Jun 1, 2015
@weaverryan weaverryan added hasPR A Pull Request has already been submitted for this issue. and removed actionable Clear and specific issues ready for anyone to take them. labels Nov 27, 2015
@weaverryan
Copy link
Member Author

Will be fixed in #5908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue. Security
Projects
None yet
Milestone
2.8
Development

No branches or pull requests
2 participants
@weaverryan @xabbuh