Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable leaptiering for AIX and IBM i for 13.4 #21

Open
abmusse opened this issue Feb 26, 2025 · 2 comments
Open

Disable leaptiering for AIX and IBM i for 13.4 #21

abmusse opened this issue Feb 26, 2025 · 2 comments

Comments

@abmusse
Copy link

abmusse commented Feb 26, 2025

Hi @targos I'm currently working thorugh resolving issues with mksnapshot that were introduced after enabling leaptiering.

More details here: https://chromium-review.googlesource.com/c/v8/v8/+/6261390/1..2

I would like to propose some changes to disable leaptiering for v8 13.4 on AIX and IBM i. I created a patch for the file I believe that enables leaptiering. I set a conditional to set the value to 0 on aix and IBM i.

Does it look like this patch look would work as expected?

diff --git a/tools/v8_gypfiles/features.gypi b/tools/v8_gypfiles/features.gypi
index 547906f663..0214bec80d 100644
--- a/tools/v8_gypfiles/features.gypi
+++ b/tools/v8_gypfiles/features.gypi
@@ -87,6 +87,12 @@
       }, {
         'v8_enable_private_mapping_fork_optimization': 0,
       }],
+
+      ['OS in "aix os400"', {
+        'v8_enable_leaptiering': 0,
+      }, {
+        'v8_enable_leaptiering': 1,
+      }],
     ],
 
     # Variables from BUILD.gn
@@ -242,9 +248,6 @@
     # Sets -DV8_ENABLE_SANDBOX.
     'v8_enable_sandbox%': 0,
 
-    # Enable leaptiering
-    'v8_enable_leaptiering%': 1,
-
     # Experimental feature for collecting per-class zone memory stats.
     # Requires use_rtti = true
     'v8_enable_precise_zone_stats%': 0,
@targos
Copy link
Owner

targos commented Feb 27, 2025

Sure, I'll add it to my PR, thanks!

@targos
Copy link
Owner

targos commented Feb 27, 2025

Pushed to nodejs#57114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants