Skip to content

Commit f60bbf4

Browse files
committed
fix(cli/info): fix crash when checking node version
closes #9396
1 parent 4973d73 commit f60bbf4

File tree

2 files changed

+18
-10
lines changed

2 files changed

+18
-10
lines changed

.changes/tauri-info-no-node.md

+7
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
"tauri-cli": "patch:bug"
3+
"@tauri-apps/cli": "patch:bug"
4+
---
5+
6+
Fix `tauri info` crashing when Node.js is not installed.
7+

tooling/cli/src/info/env_nodejs.rs

+11-10
Original file line numberDiff line numberDiff line change
@@ -42,16 +42,17 @@ pub fn items(metadata: &VersionMetadata) -> Vec<SectionItem> {
4242
.unwrap_or_default()
4343
.trim();
4444
ActionResult::Description(format!("node: {}{}", v, {
45-
let version = semver::Version::parse(v).unwrap();
46-
let target_version = semver::Version::parse(node_target_ver.as_str()).unwrap();
47-
if version < target_version {
48-
format!(
49-
" ({}, latest: {})",
50-
"outdated".red(),
51-
target_version.to_string().green()
52-
)
53-
} else {
54-
"".into()
45+
let version = semver::Version::parse(v);
46+
let target_version = semver::Version::parse(node_target_ver.as_str());
47+
match (version, target_version) {
48+
(Ok(version), Ok(target_version)) if version < target_version => {
49+
format!(
50+
" ({}, latest: {})",
51+
"outdated".red(),
52+
target_version.to_string().green()
53+
)
54+
}
55+
_ => "".into(),
5556
}
5657
}))
5758
} else {

0 commit comments

Comments
 (0)