Skip to content

Commit 181645b

Browse files
authored
feat: More strictly handle resource compiler issues. (#20)
1 parent a9130d4 commit 181645b

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

.changes/manifest-required.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
winres: minor
3+
---
4+
5+
`winres` is now more strict about `embed_resource`'s result (using manifest_required instead of manifest_option) and therefore may panic more likely, for example if the environment is missing a resource compiler.

src/lib.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -533,7 +533,7 @@ impl WindowsResource {
533533

534534
// This matches v2 behavior
535535
embed_resource::compile(rc, embed_resource::NONE)
536-
.manifest_optional()
536+
.manifest_required()
537537
.unwrap();
538538

539539
Ok(())
@@ -560,7 +560,7 @@ impl WindowsResource {
560560

561561
// This matches v2 behavior
562562
embed_resource::compile_for("resource.rc", binaries, embed_resource::NONE)
563-
.manifest_optional()
563+
.manifest_required()
564564
.unwrap();
565565

566566
Ok(())

0 commit comments

Comments
 (0)