Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to maven version 3 #170

Closed
muuki88 opened this issue Jul 11, 2014 · 7 comments
Closed

Upgrading to maven version 3 #170

muuki88 opened this issue Jul 11, 2014 · 7 comments
Milestone

Comments

@muuki88
Copy link
Contributor

muuki88 commented Jul 11, 2014

Hi,

This plugin is awesome. It finally made its way as an experimental feature to the sbt-native-packager project. Using the API was pleasing. Keep up the good work.

However we have an issue [sbt/sbt-native-packager/issues/291] with slf4j. It seems
the maven-core dependency pulls in a lot of slf4j stuff. Is there any chance to update the maven version or updating slf4j?

@tcurdt
Copy link
Owner

tcurdt commented Jul 11, 2014

which version would you need?

@tmortagne
Copy link
Collaborator

@muuki88 if you use jdeb as Maven dependency you could force any slf4j version you want using . But you setup may be more complex. But the general issue if that even if jdeb upgrade now its dependency of slf4j you may have the same issue again an again (and with other dependencies since you seems to use more than jdeb).

@muuki88
Copy link
Contributor Author

muuki88 commented Jul 11, 2014

@tcurdt 1.6.x would be great.

@tmortagne , that's the current "workaround". The problem is more between maven, ivy and sbt
handling plugin dependencies weirdly (at least for me). Stil the slf4j api isn't moving at a very high pace, so a version bump to 1.6.6 will help out for months/years :)

@tmortagne
Copy link
Collaborator

Well the latest version is 1.7.7.

@muuki88
Copy link
Contributor Author

muuki88 commented Jul 11, 2014

But there seem to be no problems between the 1.6.x and the 1.7.x releases. Both worked for me (which is a nice job by the slf4j guys). However I would not argue against 1.7. The later the better.

@tmortagne tmortagne reopened this Jul 11, 2014
@tcurdt tcurdt added this to the 1.2.1 milestone Jul 11, 2014
@benmccann
Copy link
Contributor

+1 just ran into this exact issue with jdeb pulling in an old version of slf4j

@benmccann
Copy link
Contributor

Here's a pull request for this: #174

@muuki88 muuki88 closed this as completed Aug 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants