Release 1.3

[benmccann]

We're desperately eager for a new version of jdeb to fix slf4j problems that we're having in Play Framework. I ran jdeb against sbt-native-packager's own suite of debian packing integration tests and they all passed. Given that jdeb's tests are all passing and we ran it against such an extensive set of integration tests with another project I'm fairly confident that the release will be a good one. If there are any difficulties folks can always just stay with 1.2. Having more options of versions to choose from only makes it easier for people to get a version that works for them. I'd love to do more to help if there's anything I can do. Unfortunately I don't have any ability to click the magic release button so all I can do is beg and wait :-) If it were a code issue I would gladly send a patch.

Running debian / sysvinit-deb
Running debian / log-directory
Running debian / test-mapping-helpers
Running debian / test-mapping
Running debian / daemon-user-deb
Running debian / upstart-deb
Running debian / daemon-user-shell-deb
Running debian / override-control-files
Running debian / simple-jdeb
Running debian / java-app-archetype
Running debian / systemd-deb
Running debian / gen-changes
Running debian / simple-deb

[tcurdt]

Wanted to cut the release but came across this :-/

[INFO] --- maven-plugin-plugin:3.3:descriptor (mojo-descriptor) @ jdeb ---
[INFO] Using 'UTF-8' encoding to read mojo metadata.
[INFO] Applying mojo extractor for language: java-annotations
[WARNING] Deprecated @component for project field in org.vafer.jdeb.maven.DebMojo.: replace with @parameter name="${project}" @readonly
[WARNING] Deprecated @component for session field in org.vafer.jdeb.maven.DebMojo.: replace with @parameter name="${session}" @readonly
[INFO] Mojo extractor for language: java-annotations found 1 mojo descriptors.
line 7 column 4 - Error: <build> is not recognized!
line 8 column 6 - Error: <plugins> is not recognized!
line 9 column 8 - Error: <plugin> is not recognized!
line 10 column 8 - Error: <artifactid> is not recognized!
line 11 column 8 - Error: <groupid> is not recognized!
line 13 column 8 - Error: <configuration> is not recognized!


[WARNING] The parameter forkMode is deprecated since version 2.14. Use forkCount and reuseForks instead.
[WARNING] useSystemClassloader setting has no effect when not forking

[WARNING] bcprov-jdk15on-1.50.jar, bcpg-jdk15on-1.50.jar define 3 overlappping classes: 
[WARNING]   - org.bouncycastle.apache.bzip2.CBZip2InputStream
[WARNING]   - org.bouncycastle.apache.bzip2.CRC
[WARNING]   - org.bouncycastle.apache.bzip2.BZip2Constants
[WARNING] maven-shade-plugin has detected that some .class files
[WARNING] are present in two or more JARs. When this happens, only
[WARNING] one single version of the class is copied in the uberjar.
[WARNING] Usually this is not harmful and you can skeep these
[WARNING] warnings, otherwise try to manually exclude artifacts
[WARNING] based on mvn dependency:tree -Ddetail=true and the above
[WARNING] output
[WARNING] See http://docs.codehaus.org/display/MAVENUSER/Shade+Plugin

We might still have to do some cleanup.

[benmccann]

What command did you run to cause this? Are all of these warnings new and need to be fixed or just some?

[tcurdt]

mvn clean install site source:jar javadoc:jar

1. The clash of the shade plugin is bad and should be tracked down.
2. I would at least like to know what the Error: <....> is not recognized comes from/means.
3. And Deprecated @component for project field in org.vafer.jdeb.maven.DebMojo.: replace with @parameter name="${project}" @readonly sounds like an easy fix.

[muuki88]

The error in 2. is cause by the javadoc here. If you remove this, the "error" disappears. The Maven-Plugin javadoc processing stuff seems to get irritated.

For 3. I'll provide I pull request.

[muuki88]

The clash in 1. is a bit suprising as bcpg-jdk15on-1.50 has a dependency on bcprov-jdk15on-1.50. Both are even build in the same reactor build, so this isn't a problem IMHO.

[tcurdt]

OK, let's ignore 2) and fix 3) and let's check what classes are causing the clash.

[benmccann]

I extracted the jars and checked the md5 checksum of each of the classes. The files are exactly the same in both jars:

2874d4071fec566e75f58cdd298f7ee3  ./org/bouncycastle/apache/bzip2/CBZip2InputStream.class
8f8b8e09021785f6d03eddd4d26aa588  ./org/bouncycastle/apache/bzip2/CRC.class
698ce314b17e29964df1b8ce65b22b65  ./org/bouncycastle/apache/bzip2/BZip2Constants.class

So it shouldn't matter that these files are in two jars since it will end up with the same exact version of both regardless of which jar they're loaded from. There's really no way to fix this except to fix it in the bouncy castle jars, so I've filed an issue there. Also, this issue exists in the current release of jdeb as well. The only difference is that we're now using a newer version of the shade plugin which is now printing a warning whereas it didn't print a warning before.

@tcurdt thanks so much for trying to cut a release. I think all the issues have been addressed now, but let us know if there's anything else that might block a release.

[benmccann]

Ok, got a new release pushed for bouncycastle which fixes the warning being printed out related to it. Here's a pull request to fix the warning: #177

[muuki88]

Awesome detective work @benmccann !

[tcurdt]

Fantastic team effort, guys 6156c86

[tcurdt]

Just released 1.3!

[muuki88]

Open Source rocks! :)

[tcurdt]

amen to that :)

[benmccann]

Awesome. Thank you guys so much for all the help! Really glad we could make so much progress together.