From da36fea101db90746d6fa404685261bf6c64835a Mon Sep 17 00:00:00 2001 From: Littleor Date: Tue, 29 Mar 2022 19:41:18 +0800 Subject: [PATCH 1/2] Support for Chinese and other UTF8 characters as folder names to switch Runs --- tensorboard/components/tf_storage/storage.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tensorboard/components/tf_storage/storage.ts b/tensorboard/components/tf_storage/storage.ts index 8268ed00a8..0ae31e3961 100644 --- a/tensorboard/components/tf_storage/storage.ts +++ b/tensorboard/components/tf_storage/storage.ts @@ -87,8 +87,8 @@ export const { getObserver: getObjectObserver, disposeBinding: disposeObjectBinding, } = makeBindings( - (s) => JSON.parse(atob(s)) as Record, - (o) => btoa(JSON.stringify(o)) + (s) => JSON.parse(decodeURIComponent(escape(window.atob(s)))) as Record, + (o) => btoa(unescape(encodeURIComponent(JSON.stringify(o)))) ); export interface StorageOptions { defaultValue?: T; From 2089e874ea1cf8c0e8bcedfc773c7d4e906f9f39 Mon Sep 17 00:00:00 2001 From: Littleor Date: Mon, 25 Apr 2022 09:15:31 +0800 Subject: [PATCH 2/2] ESLint fixed --- tensorboard/components/tf_storage/storage.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tensorboard/components/tf_storage/storage.ts b/tensorboard/components/tf_storage/storage.ts index 0ae31e3961..c16917aed5 100644 --- a/tensorboard/components/tf_storage/storage.ts +++ b/tensorboard/components/tf_storage/storage.ts @@ -87,7 +87,11 @@ export const { getObserver: getObjectObserver, disposeBinding: disposeObjectBinding, } = makeBindings( - (s) => JSON.parse(decodeURIComponent(escape(window.atob(s)))) as Record, + (s) => + JSON.parse(decodeURIComponent(escape(window.atob(s)))) as Record< + string, + string + >, (o) => btoa(unescape(encodeURIComponent(JSON.stringify(o)))) ); export interface StorageOptions {