Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model detection by SKU Number #45

Closed
texhex opened this issue Mar 20, 2018 · 2 comments
Closed

Add model detection by SKU Number #45

texhex opened this issue Mar 20, 2018 · 2 comments

Comments

@texhex
Copy link
Owner

texhex commented Mar 20, 2018

In case someone is using the same model but with two different configurations, the current model detection by name can not handle this.

For example, the EliteBook 840 G4 as non-vPro device could be SKU Z2V60EA#ABV but the same model with vPro could be X3V00AV. Because the non-vPro device is missing several BIOS settings (e.g. Intel TXT) and some configuration items are named differently (e.g. HBMA Network card names), trying to use the same configuration both items will not work.

The SKU check should be performed before the name check to allow a special configuration where the SKU matches.

@texhex
Copy link
Owner Author

texhex commented Mar 26, 2018

Added in 50d8f95, but documentation is missing.

@texhex
Copy link
Owner Author

texhex commented Apr 7, 2018

4.0.5 contains this change, closing issue.

@texhex texhex closed this as completed Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant