Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to always expose the interval param for the device code grant #1464

Closed
erickskrauch opened this issue Dec 6, 2024 · 1 comment · Fixed by #1410
Closed

Add an option to always expose the interval param for the device code grant #1464

erickskrauch opened this issue Dec 6, 2024 · 1 comment · Fixed by #1410

Comments

@erickskrauch
Copy link
Contributor

The title. I want to always expose the interval param. Clients aren't always responsible for reading the standard to know that the poll interval defaults to 5 seconds. Microsoft and Google always return this parameter.

My suggestion is simply to remove the next condition:

if ($this->deviceCodeEntity->getInterval() !== self::DEFAULT_INTERVAL) {
$responseParams['interval'] = $this->deviceCodeEntity->getInterval();
}

@hafezdivandari
Copy link
Contributor

You may refer to #1410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants