Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the efforts #1

Open
unkcpz opened this issue Feb 24, 2025 · 0 comments
Open

Merge the efforts #1

unkcpz opened this issue Feb 24, 2025 · 0 comments

Comments

@unkcpz
Copy link

unkcpz commented Feb 24, 2025

Hi @iharthi, I hope I found your package earlier!

In one of our project, we need the keyring support for python which also support keyutils. Sadly last week I didn't notice your package and I make a similar wrapper based on keyring-rs and public as https://github.com/unkcpz/keyringrs. I think it would be great to have only one support for such tool and to make it more exposed to the community.

I am very open to move my changes to your repo here and we maintain it together. What do you think? (from the team, we compromise to use python keyring and ignore the requirement of keyutils, simply because it has more community exposure. If there is a popular solution exist so people know there is an active maintained package exist it is straightforward to have have this better solution)

FYI, you can also check the discussion in hwchen/keyring-rs#234

Some ideas and questions to move forward:

  • the keyring-rs has more generic API for cross-platform, so for native keyutils support it may requires some APIs for keyutils only. I think your package has basic support which covered by keyring-rs at the moment. Do you plan to have support for features such as process scope keyring which I assume very specific to keyutils (maybe macOS keychain has similar support)?
  • I can feel with rust as backend, the memory management when working with password can be better. It would be better to have some allocation profiling.
  • In my wrapper, I don't convert proper errors into corresponding exceptions as you mentioned in the readme.

I saw you have CI that publish to pypi, but I can not find it. Could you provide the link to it? Would be nice to know which to install through pip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant