Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use grid store instead of initializing grid in each page #1427

Closed
zaelgohary opened this issue Nov 16, 2023 · 3 comments
Closed

Use grid store instead of initializing grid in each page #1427

zaelgohary opened this issue Nov 16, 2023 · 3 comments
Assignees
Labels
playground type_feature New feature or request
Milestone

Comments

@zaelgohary
Copy link
Contributor

Refactor the playground to use grid store instead of creating multiple instances for the grid.

@ramezsaeed ramezsaeed added the type_feature New feature or request label Nov 19, 2023
@ramezsaeed ramezsaeed added this to the 2.4.0 milestone Nov 19, 2023
@zaelgohary zaelgohary self-assigned this Feb 5, 2024
@zaelgohary zaelgohary moved this to In Progress in 3.14.x Feb 5, 2024
@zaelgohary
Copy link
Contributor Author

While I was refactoring, I found that each solution provides its project name while adding/deleting the machine. This is not implemented in the current store. Should the project name be provided dynamically while creating any deployment? I'm not sure if this is possible as we set the grid value only when the user logs in. What do you think? @MohamedElmdary

@MohamedElmdary
Copy link
Member

@zaelgohary no we should use updateGrid(store.client, { projectName: "whatever" } )

@zaelgohary zaelgohary moved this from In Progress to Accepted in 3.14.x Feb 6, 2024
@AhmedHanafy725 AhmedHanafy725 modified the milestones: 2.4.0, 2.5.0 Mar 25, 2024
@zaelgohary zaelgohary moved this from Accepted to In Progress in 3.14.x Apr 15, 2024
@zaelgohary zaelgohary moved this from In Progress to Pending Review in 3.14.x Apr 15, 2024
@zaelgohary
Copy link
Contributor Author

Work completed:

Replaced all new grid instances with grid store.

@zaelgohary zaelgohary moved this from Pending Review to In Verification in 3.14.x May 9, 2024
@github-project-automation github-project-automation bot moved this from In Verification to Done in 3.14.x Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
playground type_feature New feature or request
Projects
Status: Done
Development

No branches or pull requests

4 participants