Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a margin above the footer #2261

Closed
A-Harby opened this issue Feb 26, 2024 · 3 comments
Closed

Add a margin above the footer #2261

A-Harby opened this issue Feb 26, 2024 · 3 comments
Assignees
@samaradel
Labels
dashboard type_bug Something isn't working
Milestone
2.4.0

Comments

@A-Harby
Copy link
Contributor

A-Harby commented Feb 26, 2024

Description

A clear description of the bug:

There should be a margin between the footer and table, or on any other page.
image

Must include any relevant identifiers like:
@A-Harby A-Harby added type_bug Something isn't working dashboard labels Feb 26, 2024
@ramezsaeed ramezsaeed added this to 3.14.x Mar 3, 2024
@ramezsaeed ramezsaeed added this to the 2.4.0 milestone Mar 3, 2024
@0oM4R 0oM4R moved this to Accepted in 3.14.x Mar 3, 2024
@samaradel samaradel moved this from Accepted to In Progress in 3.14.x Mar 4, 2024
@samaradel samaradel self-assigned this Mar 4, 2024
@samaradel samaradel mentioned this issue Mar 4, 2024
Merged
5 tasks
@samaradel samaradel moved this from In Progress to Pending Review in 3.14.x Mar 4, 2024
@samaradel
Copy link
Contributor

Work Completed

Add some margin-top to the footer

@0oM4R 0oM4R moved this from Pending Review to In Verification in 3.14.x Mar 4, 2024
@0oM4R 0oM4R moved this from In Verification to Pending Deployment in 3.14.x Mar 4, 2024
@AhmedHanafy725 AhmedHanafy725 moved this from Pending Deployment to In Verification in 3.14.x Mar 19, 2024
@A-Harby
Copy link
Contributor Author

A-Harby commented Mar 26, 2024

Verified, Devnet bd6c7c5.

I checked all the pages with a table or a border, and a space was added between them and the footer.
image
image
image
image
image

@A-Harby A-Harby moved this from In Verification to Done in 3.14.x Mar 26, 2024
@ramezsaeed
Copy link
Contributor

Verified:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samaradel samaradel

Labels
dashboard type_bug Something isn't working
Projects
3.14.x
Status: Done
Milestone
2.4.0
Development

No branches or pull requests
3 participants
@samaradel @ramezsaeed @A-Harby