Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 [Bug]: Rephrase or add tooltip to my nodes filter #3537

Closed
1 task done
0oM4R opened this issue Oct 17, 2024 · 4 comments
Closed
1 task done

🐞 [Bug]: Rephrase or add tooltip to my nodes filter #3537

0oM4R opened this issue Oct 17, 2024 · 4 comments
Assignees
Labels
dashboard type_bug Something isn't working
Milestone

Comments

@0oM4R
Copy link
Contributor

0oM4R commented Oct 17, 2024

Is there an existing issue for this?

  • I have searched the existing issues

which package/s did you face the problem with?

Dashboard

What happened?

while testing https://app.testlodge.com/a/26076/projects/40893/runs/757884/run?run_suite_id=1250709&selected=33254549
with twin id
i was expecting to list my node but i couldn't, after checking the request i found that rentedBy param is passed
i suggest to change the filter name, or add a tooltip

Steps To Reproduce

No response

which network/s did you face the problem on?

Dev

version

fccc6af

Twin ID/s

9091

Node ID/s

263

Farm ID/s

No response

Contract ID/s

No response

Relevant screenshots/screen records

.

Relevant log output

.
@0oM4R 0oM4R added the type_bug Something isn't working label Oct 17, 2024
@ramezsaeed ramezsaeed added this to the 2.7.0 milestone Oct 20, 2024
@0oM4R
Copy link
Contributor Author

0oM4R commented Oct 23, 2024

change the label to be my rented nodes.
and we can check with @ehab-hassan

@0oM4R 0oM4R moved this to Accepted in 3.16.x Oct 23, 2024
@samaradel samaradel self-assigned this Oct 23, 2024
@samaradel samaradel moved this from Accepted to In Progress in 3.16.x Oct 23, 2024
@ehab-hassan
Copy link
Contributor

ehab-hassan commented Oct 23, 2024

I think "My rented nodes" is more Fiendelly than "Node rented by me"
so let go with "My Rented Nodes"

@samaradel samaradel moved this from In Progress to Pending Review in 3.16.x Oct 23, 2024
@samaradel
Copy link
Contributor

Work Completed:

Re-phase My Node switch and vars across the nodes page.

@samaradel samaradel moved this from Pending Review to In Verification in 3.16.x Oct 24, 2024
@atefnazmy
Copy link

atefnazmy commented Dec 2, 2024

-Verified on Dev,
-Version: 4e2fc0b
-The toggle button is currently named "My Rented Nodes"

rented_Nodes

Related Link :

https://app.testlodge.com/a/26076/projects/40893/suites/234374?expand_section=426661#case_4335955

@atefnazmy atefnazmy moved this from In Verification to Done in 3.16.x Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard type_bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

5 participants