From 81e34e41ccb68a6e719fe5596b9b577b72999367 Mon Sep 17 00:00:00 2001 From: Mahmoud Emad Date: Thu, 4 Apr 2024 13:20:59 +0200 Subject: [PATCH 1/2] Update: Remove the undefined/empty-string values from the request url. --- packages/gridproxy_client/src/modules/abstract_client.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/packages/gridproxy_client/src/modules/abstract_client.ts b/packages/gridproxy_client/src/modules/abstract_client.ts index d1b249e420..068b98c2be 100644 --- a/packages/gridproxy_client/src/modules/abstract_client.ts +++ b/packages/gridproxy_client/src/modules/abstract_client.ts @@ -13,6 +13,12 @@ export abstract class AbstractClient { } public builder(queries: Partial = {}): B { + for (const key of Object.keys(queries)) { + if (!queries[key]) { + delete queries[key]; + } + } + return new this.__Builder(this.uri, queries); } } From 045ffdd51bc0b88483aff89691382e538d380392 Mon Sep 17 00:00:00 2001 From: Mahmoud Emad Date: Thu, 4 Apr 2024 13:30:31 +0200 Subject: [PATCH 2/2] Fix: Updated the condition to remove the undefined and empty string values instead of the 'false' values. --- packages/gridproxy_client/src/modules/abstract_client.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/gridproxy_client/src/modules/abstract_client.ts b/packages/gridproxy_client/src/modules/abstract_client.ts index 068b98c2be..d72d7bd58f 100644 --- a/packages/gridproxy_client/src/modules/abstract_client.ts +++ b/packages/gridproxy_client/src/modules/abstract_client.ts @@ -14,7 +14,7 @@ export abstract class AbstractClient { public builder(queries: Partial = {}): B { for (const key of Object.keys(queries)) { - if (!queries[key]) { + if (queries[key] === undefined || queries[key] === "" || queries[key] === null) { delete queries[key]; } }