Skip to content

Commit d6fbce9

Browse files
committed
remove "optimal" option for weight_func()
1 parent af64759 commit d6fbce9

File tree

4 files changed

+8
-5
lines changed

4 files changed

+8
-5
lines changed

NEWS.md

+4
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,12 @@
1111

1212
* For space-filling designs for $p$ parameters, there is a higher likelihood of finding a space-filling design for `1 < size <= p`. Also, single-point designs now default to a random grid (#363).
1313

14+
## Breaking changes
15+
1416
* The `grid_*()` functions now error instead of warn when provided with the wrong argument to control the grid size. So `grid_space_filling()`, `grid_random()`, `grid_max_entropy()`, and `grid_latin_hypercube()` now error if used with a `levels` argument and `grid_regular()` now errors if used with a `size` argument (#368).
1517

18+
* The `"optimal"` option for the `weight_func()` parameter has been removed since it is choosing the optimal value based on the resubstition error (#370).
19+
1620

1721
# dials 1.3.0
1822

R/param_weight_func.R

+1-2
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,5 @@ values_weight_func <- c(
2929
"cos",
3030
"inv",
3131
"gaussian",
32-
"rank",
33-
"optimal"
32+
"rank"
3433
)

man/weight_func.Rd

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/testthat/_snaps/constructors.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -187,9 +187,9 @@
187187
print(fun_ish)
188188
Message
189189
Qualitative Parameter
190-
10 possible values include:
190+
9 possible values include:
191191
'rectangular', 'triangular', 'epanechnikov', 'biweight', 'triweight', 'cos',
192-
'inv', 'gaussian', 'rank', and 'optimal'
192+
'inv', 'gaussian', and 'rank'
193193

194194
---
195195

0 commit comments

Comments
 (0)