Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom dark/light theming #737

Open
simonpcouch opened this issue Oct 4, 2023 · 0 comments
Open

Custom dark/light theming #737

simonpcouch opened this issue Oct 4, 2023 · 0 comments
Labels
upkeep maintenance, infrastructure, and similar

Comments

@simonpcouch
Copy link
Contributor

The symbol.R file contains some functionality for custom logging colors:

tune/R/symbol.R

Lines 19 to 24 in f6300b1

# To remove the crayon dependency, use the cli analogs. However, these
# produce ansi_string objects and some of our logging code needs
# the character values. Will not be needed for cli >= 2.1.0.9000
yellow <- function(...) as.character(cli::col_yellow(...))
black <- function(...) as.character(cli::col_black(...))
white <- function(...) as.character(cli::col_white(...))

Initiated in .onLoad():

tune/R/zzz.R

Lines 38 to 39 in f6300b1

makeActiveBinding(
"tune_color",

In the time since this code written, cli has matured greatly. I'd urge us to consider deprecating the tune_color active binding in .onLoad() in favor of cli's palette infrastructure.

@simonpcouch simonpcouch added the upkeep maintenance, infrastructure, and similar label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

No branches or pull requests

1 participant