Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upkeep for readr #1372

Closed
18 of 23 tasks
jennybc opened this issue Feb 28, 2022 · 3 comments
Closed
18 of 23 tasks

Upkeep for readr #1372

jennybc opened this issue Feb 28, 2022 · 3 comments
Assignees

Comments

@jennybc
Copy link
Member

jennybc commented Feb 28, 2022

Pre-history

  • usethis::use_readme_rmd()
  • usethis::use_roxygen_md()
  • usethis::use_github_links()
  • usethis::use_pkgdown_github_pages()
  • usethis::use_tidy_github_labels()
  • usethis::use_tidy_style()
  • usethis::use_tidy_description()
  • urlchecker::url_check()

2020

  • usethis::use_package_doc()
    Consider letting usethis manage your @importFrom directives here.
    usethis::use_import_from() is handy for this.
  • usethis::use_testthat(3) and upgrade to 3e, testthat 3e vignette
  • Align the names of R/ files and test/ files for workflow happiness.
    usethis::rename_files() can be helpful.

2021

  • usethis::use_tidy_dependencies()
  • usethis::use_tidy_github_actions() and update artisanal actions to use setup-r-dependencies
  • Remove check environments section from cran-comments.md
  • Bump required R version in DESCRIPTION to 3.4
  • Use lifecycle instead of artisanal deprecation messages, as described in Communicate lifecycle changes in your functions

2022

@jennybc
Copy link
Member Author

jennybc commented Mar 7, 2022

Before we close this @sbearrows, let's follow up on items that are struck through.

usethis::use_tidy_dependencies(): We aren't implementing this now, in the absence of specific plans to take advantage of it. But let's note what would change in readr, because it means we should have a low threshold for making these changes in the future:

  • Add glue to Imports. If using glue would be handy, we should just do it.
  • Move withr from Suggests to Imports. If wider internal use of withr would be handy, do it.
  • Import rlang's namespace.
  • Add the purrr compatibility file.

pkgdown: Nothing needs to be done for readr because it's already been modernized and re-published. readr was one of the "guinea pig" packages where our update procedure was worked out.

Update errors to rlang 1.0.0: I don't understand why this is struck through. Or, rather, it feels like we should open a new separate issue about using rlang for conditions in readr.

@sbearrows Will you confirm / comment on the above?

@sbearrows
Copy link
Contributor

Yes, I still need to open a new issue for the item "Update errors to rlang 1.0.0" which I will link to here.

Otherwise, I think everything else you've mentioned covers items that are struck through.

Thanks for helping me document these last few items!

@jennybc
Copy link
Member Author

jennybc commented Mar 8, 2022

Ok I think we are done!

@jennybc jennybc closed this as completed Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants