Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raft : Incorrect learner checking in handle_transfer_leader #164

Closed
Fullstop000 opened this issue Jan 16, 2019 · 2 comments
Closed

raft : Incorrect learner checking in handle_transfer_leader #164

Fullstop000 opened this issue Jan 16, 2019 · 2 comments
Labels
Bug Recognized misbehavior.

Comments

@Fullstop000
Copy link
Member

https://github.com/pingcap/raft-rs/blob/2bd26cea006a67a36778adbcc3525f83765c044d/src/raft.rs#L1206-L1211
Here we should check whether target Progress is a learner instead and besides self.is_learner is never true since self is the leader.
@BusyJay
Copy link
Member

BusyJay commented Jan 16, 2019

@hicqu PTAL

@BusyJay BusyJay added the Question A question to be answered. label Jan 16, 2019
@Fullstop000 Fullstop000 mentioned this issue Jan 17, 2019
Merged
@Hoverbear Hoverbear added Bug Recognized misbehavior. and removed Question A question to be answered. labels Jan 18, 2019
@hicqu
Copy link
Contributor

hicqu commented Jan 18, 2019

Nice catch, thank you. I will fix it soon later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Recognized misbehavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Hoverbear @BusyJay @hicqu @Fullstop000