Remove session access from controller constructor

Prevents sticking to bad practice and stages enhancement for L5.3

Discussion:

laravel/framework#15072 (comment)

Author: alariva

app/Http/Controllers/Controller.php

@@ -13,8 +13,6 @@ class Controller extends BaseController
 
     public function __construct()
     {
-        view()->share('isGuest', auth()->guest());
-        view()->share('signedIn', auth()->check());
-        view()->share('user', auth()->user());
+        //
     }
 }

app/Http/Controllers/User/UserPreferencesController.php

@@ -8,23 +8,14 @@
 
 class UserPreferencesController extends Controller
 {
-    protected $user;
-
-    public function __construct()
-    {
-        parent::__construct();
-
-        $this->user = auth()->user();
-    }
-
     public function getPreferences()
     {
         logger()->info(__METHOD__);
 
         // BEGIN
 
         $parameters = config()->get('preferences.App\Models\User');
-        $preferences = $this->user->preferences;
+        $preferences = auth()->user()->preferences;
 
         return view('user.preferences.edit', compact('preferences', 'parameters'));
     }
@@ -60,13 +51,13 @@ protected function setUserPreferences($preferences)
         foreach ($mergedPreferences as $key => $value) {
             logger()->info(sprintf(
                 "set preference: UserId:%s key:%s='%s' type:%s",
-                $this->user->id,
+                auth()->user()->id,
                 $key,
                 $value,
                 $parameters[$key]['type']
             ));
 
-            $this->user->pref($key, $value, $parameters[$key]['type']);
+            auth()->user()->pref($key, $value, $parameters[$key]['type']);
         }
     }
 }

app/Providers/ComposerServiceProvider.php

@@ -22,7 +22,7 @@ public function boot()
         );
 
         view()->composer(
-            ['layouts.app', 'layouts.user'], \App\Http\ViewComposers\AuthComposer::class
+            ['*'], \App\Http\ViewComposers\AuthComposer::class
         );
 
         view()->composer(