-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move away from zip and use tar+gzip instead #343
Comments
While someone is at it, xz (LZMA) compression is preferred to gzip. |
@Ostera do you think we need it? IMO it does not solve any problem at the moment, but may create potential issues for the clients who rely on it. |
Ultimately using Then there's another advantage, which is using
|
@Ostera |
Precious kilobytes! I'd introduce gzip in the next release and then drop zip support on the one after that so people have time to migrate. |
They are precious. |
Closing it as discussed on tldr-pages/tldr-node-client#9. TLDR: Clients should prefer git over manually downloading .zip archives. |
Since we're talking about roughly 100kB for the whole archive, smaller than most current webpages, I think downloading the whole archive shouldn't be such a problem every once in a while. |
@pepa65 while that approach may work now, IMO it's neither scalable nor elegant. But in any case, this issue was created back when clients (especially the node one) were tightly coupled to the tldr-pages repo, and we want to move away from that, by providing a spec that any client can follow. So, as long as the clients follow the spec's recommendations, they could still use the full zip download approach, since the archives (tldr.zip and index.json) are currently still being generated upon every commit to this repo. We won't invest time changing the format of the archive as suggested on this issue, since we don't recommend that method of updating clients' local cache of pages, and we won't commit to support the archive generation indefinitely (e.g. if some part of the pipeline breaks), but we won't go out of our way to deliberately curtail that service, either -- not without previous discussion with the clients' authors, at least :) |
Just about that. Refactor the build scripts so they use
tar
instead.It'd require refactoring the
node-client
to usenode-tar
instead ofunzip2
. But that should be fairly straightforward since they share the same.Extract
interface.The text was updated successfully, but these errors were encountered: