Skip to content
This repository was archived by the owner on Jan 2, 2023. It is now read-only.

Review protected methods and consider making some private #113

Closed
tobyzerner opened this issue Mar 5, 2017 · 2 comments
Closed

Review protected methods and consider making some private #113

tobyzerner opened this issue Mar 5, 2017 · 2 comments

Comments

@tobyzerner
Copy link
Owner

In preparation for a 1.0 release.

@tobyzerner
Copy link
Owner Author

Specifically:

  • Document::getIncluded() (would also like to see if this logic can be cleaned up a bit)
  • Document::mergeResource()
  • LinksTrait::addPaginationLink()
  • Parameters::getInput()
  • Parameters::getPage()
  • Many methods in Resource

@tobyzerner
Copy link
Owner Author

Fixed in #119

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant