core/state/snapshot: fix panic on missing parent

karalabe · karalabe · commit a31f6d54dfd4 · 2021-03-22T22:41:28.000+02:00
diff --git a/core/state/snapshot/snapshot.go b/core/state/snapshot/snapshot.go
@@ -283,11 +283,11 @@ func (t *Tree) Update(blockRoot common.Hash, parentRoot common.Hash, destructs m
 		return errSnapshotCycle
 	}
 	// Generate a new snapshot on top of the parent
-	parent := t.Snapshot(parentRoot).(snapshot)
+	parent := t.Snapshot(parentRoot)
 	if parent == nil {
 		return fmt.Errorf("parent [%#x] snapshot missing", parentRoot)
 	}
-	snap := parent.Update(blockRoot, destructs, accounts, storage)
+	snap := parent.(snapshot).Update(blockRoot, destructs, accounts, storage)
 
 	// Save the new snapshot for later
 	t.lock.Lock()

Original file line number	Diff line number	Diff line change
`@@ -283,11 +283,11 @@ func (t *Tree) Update(blockRoot common.Hash, parentRoot common.Hash, destructs m`
`283`	`283`	`return errSnapshotCycle`
`284`	`284`	`}`
`285`	`285`	`// Generate a new snapshot on top of the parent`
`286`		`- parent := t.Snapshot(parentRoot).(snapshot)`
	`286`	`+ parent := t.Snapshot(parentRoot)`
`287`	`287`	`if parent == nil {`
`288`	`288`	`return fmt.Errorf("parent [%#x] snapshot missing", parentRoot)`
`289`	`289`	`}`
`290`		`- snap := parent.Update(blockRoot, destructs, accounts, storage)`
	`290`	`+ snap := parent.(snapshot).Update(blockRoot, destructs, accounts, storage)`
`291`	`291`
`292`	`292`	`// Save the new snapshot for later`
`293`	`293`	`t.lock.Lock()`