Deprecate Alert#authenticate

It's not supported by any drivers anymore and is not spec-compliant.
Watch w3c/webdriver#385 for updates.

Author: p0deje

lib/selenium/webdriver/common/alert.rb

@@ -44,6 +44,7 @@ def text
       end
 
       def authenticate(username, password)
+        WebDriver.logger.deprecate 'Alert#authenticate'
         @bridge.authentication(username: username, password: password)
         accept
       end

lib/selenium/webdriver/common/logger.rb

@@ -101,13 +101,20 @@ def io
       end
 
       #
-      # Marks code as deprecated with replacement.
+      # Marks code as deprecated with/without replacement.
       #
       # @param [String] old
-      # @param [String] new
+      # @param [String, nil] new
       #
-      def deprecate(old, new)
-        warn "[DEPRECATION] #{old} is deprecated. Use #{new} instead."
+      def deprecate(old, new = nil)
+        message = "[DEPRECATION] #{old} is deprecated"
+        message << if new
+                     ". Use #{new} instead."
+                   else
+                     ' and will be removed in the next releases.'
+                   end
+
+        warn message
       end
 
       private

spec/integration/selenium/webdriver/spec_support/rack_server.rb

@@ -123,29 +123,10 @@ def call(env)
               body = req['upload'][:tempfile].read
 
               [200, {'Content-Type' => 'text/html'}, [body]]
-            when '/basicAuth'
-              if authorized?(env)
-                status = 200
-                header = {'Content-Type' => 'text/html'}
-                body = '<h1>authorized</h1>'
-              else
-                status = 401
-                header = {'WWW-Authenticate' => 'Basic realm="basic-auth-test"'}
-                body = 'Login please'
-              end
-
-              [status, header, [body]]
             else
               @static.call env
             end
           end
-
-          private
-
-          def authorized?(env)
-            auth = Rack::Auth::Basic::Request.new(env)
-            auth.provided? && auth.basic? && auth.credentials && auth.credentials == BASIC_AUTH_CREDENTIALS
-          end
         end
       end # RackServer
     end # SpecSupport

spec/integration/selenium/webdriver/target_locator_spec.rb

@@ -348,32 +348,6 @@ module WebDriver
           end
         end
       end
-
-      compliant_on browser: :ie do
-        # Windows 10 changed the auth alert
-        not_compliant_on browser: :ie do
-          describe 'basic auth alerts' do
-            after { reset_driver! }
-
-            it 'allows the user to send valid credentials to an alert' do
-              driver.navigate.to url_for('basicAuth')
-              driver.switch_to.alert.authenticate('test', 'test')
-
-              expect(driver.find_element(tag_name: 'h1').text).to eq('authorized')
-            end
-
-            it 'does not raise an error when invalid credentials are used' do
-              driver.navigate.to url_for('basicAuth')
-              driver.switch_to.alert.authenticate('invalid', 'invalid')
-
-              wait = Selenium::WebDriver::Wait.new(timeout: 5, ignore: Selenium::WebDriver::Error::NoSuchAlertError)
-              wait.until { driver.switch_to.alert }
-
-              expect { driver.switch_to.alert.dismiss }.to_not raise_error
-            end
-          end
-        end
-      end
     end
   end # WebDriver
 end # Selenium

spec/unit/selenium/webdriver/common/logger_spec.rb

@@ -58,10 +58,15 @@ module WebDriver
         end
       end
 
-      it 'allows to deprecate functionality' do
+      it 'allows to deprecate functionality with replacement' do
         message = /WARN Selenium \[DEPRECATION\] #old is deprecated\. Use #new instead\./
         expect { WebDriver.logger.deprecate('#old', '#new') }.to output(message).to_stdout
       end
+
+      it 'allows to deprecate functionality without replacement' do
+        message = /WARN Selenium \[DEPRECATION\] #old is deprecated and will be removed in the next releases\./
+        expect { WebDriver.logger.deprecate('#old') }.to output(message).to_stdout
+      end
     end
   end # WebDriver
 end # Selenium