Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move operations not requiring numerical properties to BasicOps #2832

Open
8000thCube opened this issue Feb 21, 2025 · 2 comments
Open

Move operations not requiring numerical properties to BasicOps #2832

8000thCube opened this issue Feb 21, 2025 · 2 comments

Comments

@8000thCube
Copy link

full, full_like, equal_elem, not_equal_elem, mask_where, mask_fill, gather, scatter, select, and select_assign have nothing to do with numerical properties and should be moved, allowing their use on Bool Tensors. This could be useful in situations like making complex masks. zeros and ones could also be moved, and correspond to false and true in bool case.

@antimora
Copy link
Collaborator

Linking the related ticket: #1535

Mainly bool elem type was not supported back then. I am not sure if we still have this blocker. @laggui maybe can tell us.

@laggui
Copy link
Member

laggui commented Feb 25, 2025

Mainly bool elem type was not supported back then. I am not sure if we still have this blocker.

Bool is implemented and the backend also has an associative type for BoolElem: Element, so should be fine on that front.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants