Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .360 video mode (MAX) #28

Closed
himynamesdave opened this issue Nov 16, 2023 · 3 comments
Closed

Add .360 video mode (MAX) #28

himynamesdave opened this issue Nov 16, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@himynamesdave
Copy link
Member

himynamesdave commented Nov 16, 2023

Currently we suppport .mp4 video mode.

GoPro MAX cameras also produce a .360 video format.

For GoPro MAX Unprocessed Video mode (.360):

  1. takes GoPro .360 video (equirectangular) with GPMF data
  2. converts to an equirectangular frames
  3. optionally adds a nadir to the resulting video
  4. stores output/uploads output/etc

GoPro2GSV validates .360 inputs before processing as follows;

  • file extension must be .360
  • filenames must start with GS
  • GoPro:Model is GoPro Max
  • trackN:MetaFormat is gpmd
  • trackN:GPSDateTime has more than 10 entries.

Where trackN is the track that contains the gpmd telemetry.

For processing, the same flags as .mp4 video mode can be used, and the processing is somewhat similar to mp4.

ffmpeg first extracts frames. However, these frames need to be converted to equirectangular projection (because GoPro .360 is EAC format).

We already have some old code to join

Note: resusing code is fine, but do not copy the whole codebase of this implementation.

After this, the GPS points are then embedded to the equirectangular images (same as #26) and the final video is processed in the same way as the image->video pipeline including the new function; #25

@himynamesdave himynamesdave added the enhancement New feature or request label Nov 16, 2023
@himynamesdave himynamesdave changed the title Add .360 video mode Add .360 video mode (MAX) Nov 16, 2023
@fqrious
Copy link
Contributor

fqrious commented Nov 20, 2023

about this, should I require a path to max2sphere binary or should I assume the user has this fork of ffmpeg

@himynamesdave
Copy link
Member Author

@fqrious ask for max2sphere binary (ideally clone it on install as a gitmodule). This is what https://github.com/trek-view/gopro2frames does

@himynamesdave
Copy link
Member Author

closing, will raise individual issue separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants