Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error in modal if user navigates (via url) to a page that gives an error #1325

Open
laholstege opened this issue Sep 29, 2023 · 4 comments
Assignees

Comments

@laholstege
Copy link
Contributor

e.g. /people/details/{person.id}/equipment/details/{id that does not exist or is not assigned to user}
or just /equipment/details/{equipment id that does not exist}

@laholstege laholstege self-assigned this Sep 29, 2023
@jSylvestre
Copy link
Member

Shouldn't that go to our error page instead of a modal?

@laholstege laholstege changed the title add error modal if user navigates (via url) to a page that gives an error add error in modal if user navigates (via url) to a page that gives an error Sep 29, 2023
@laholstege
Copy link
Contributor Author

i was just picturing an error within the modals, currently nothing renders

@jSylvestre
Copy link
Member

How about a toast for that?

@laholstege
Copy link
Contributor Author

yeah, i'm good with that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants