Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .env & private.json Checks within Action Pipeline #189

Closed
AlexanderWangY opened this issue Feb 26, 2024 · 1 comment · Fixed by #198
Closed

Add .env & private.json Checks within Action Pipeline #189

AlexanderWangY opened this issue Feb 26, 2024 · 1 comment · Fixed by #198
Assignees
@Phantom0110
Labels
Easy A simple problem or change that needs to be fixed or made. Good first issue Good for newcomers Optimization Changes that makes functionality faster or use less memory Pipeline Changes to our Github Actions Pipeline Testing Changes made to test files & suites

Comments

@AlexanderWangY
Copy link
Collaborator

Description:

  • Ensure developers don't accidentally attempt to make a PR with secrets by making a job that scans files and checks for .env or private.json files
  • Make a separate job for this and edit it within the .github/workflows/main.yaml
  • Ensure the checks work by testing with and without a .env file and a private.json file

What's the private.json? - As we migrate over to firebase-admin in the backend, we verify api credentials using a service account object within a file we rename private.json which should be located in server/src/private/. We need to ensure this doesn't get commited to our github repo for security
@AlexanderWangY AlexanderWangY added Good first issue Good for newcomers Optimization Changes that makes functionality faster or use less memory Easy A simple problem or change that needs to be fixed or made. Testing Changes made to test files & suites Pipeline Changes to our Github Actions Pipeline labels Feb 26, 2024
@Phantom0110
Copy link
Contributor

I got this.

@AlexanderWangY AlexanderWangY mentioned this issue Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Phantom0110 Phantom0110

Labels
Easy A simple problem or change that needs to be fixed or made. Good first issue Good for newcomers Optimization Changes that makes functionality faster or use less memory Pipeline Changes to our Github Actions Pipeline Testing Changes made to test files & suites
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new code to workflows to test new pull request Phantom0110/OSC-Proximity-Chat-App
2 participants
@AlexanderWangY @Phantom0110