Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data orientation of validation results #14

Closed
mandolyte opened this issue Sep 4, 2020 · 2 comments
Closed

Data orientation of validation results #14

mandolyte opened this issue Sep 4, 2020 · 2 comments

Comments

@mandolyte
Copy link
Contributor

Basic idea: return raw atomic data in an object and let the app rendering make it into something fit for human consumption. For example consider the location field:

location: " with ID 'r3jx' in line 67 en jud book package from unfoldingword"
  • Put the line number in the dedicated field for that
  • Don't need "jud" since we already have bookID field
  • You can add a langId and ownerId and remove both "en" and "unfoldingword"

After this, then "location" is left with only "r3jx". But for human consumption, it would be trivial to reconstruct the longer messages based on the data fields.

Here is a picture from the console log:
image

@mandolyte
Copy link
Contributor Author

@RobH123 @PhotoNomad0
Until this is done, I am using regex to remove surplus information from the location field.

Also, based on discussions, @RobH123 has a better idea, namely, add two fields:

  • one to capture the id (r3jx in the above)
  • one to capture the field name (in TN this would be the column header; in other resource types, not sure what it might be).

@RobH123
Copy link
Contributor

RobH123 commented Sep 22, 2020

I think that the essence of this is achieved now by 1/ converting notices from arrays to objects, 2/ adding extra (optional) notice fields, and 3/ removing that information from the location field.

@RobH123 RobH123 closed this as completed Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants