Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-English bible names? #45

Closed
PhotoNomad0 opened this issue Sep 21, 2020 · 2 comments
Closed

Fix non-English bible names? #45

PhotoNomad0 opened this issue Sep 21, 2020 · 2 comments

Comments

@PhotoNomad0
Copy link
Contributor

CV is Currently using GLT and GST for languages other than english. We need to make sure that will always work going forward.

    const ULT = languageCode === 'en' ? 'ULT' : 'GLT';
    const UST = languageCode === 'en' ? 'UST' : 'GST';

@RobH123
Copy link
Contributor

RobH123 commented Sep 22, 2020

I'm not understanding this @PhotoNomad0. The snippet above from checkBookPackage() is correct to the best of my current understanding, although perhaps the username should also be either unfoldingWord or Door43-Catalog in order to use 'ULT' and 'UST'?

(I assume that you're aware that the U in 'ULT' and 'UST' specifically stands for 'unfoldingWord®' -- in times past it stood for generic 'Unlocked'. The G stands for generic 'Gateway Language'.)

But anyway, I'd prefer that sort of thing (i.e., all file control stuff) to be handled in the calling app.

@PhotoNomad0
Copy link
Contributor Author

It gets a bit confusing when we have a ulb for hi. Closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants