Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github pullrequest are re-created if when not needed #2039

Closed
1 task done
olblak opened this issue Apr 15, 2024 · 0 comments · Fixed by #2040 or #2054
Closed
1 task done

github pullrequest are re-created if when not needed #2039

olblak opened this issue Apr 15, 2024 · 0 comments · Fixed by #2040 or #2054
Labels
bug Something isn't working github_actions Pull requests that update Github_actions code
Milestone

Comments

@olblak
Copy link
Member

olblak commented Apr 15, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

In some situation, Updatecli can close and reopen GitHub pullrequest.

In Updatecli version 0.75.0, Updatecli introduced the ability to converge working branch which "diverged" from their base branch.
This has the consequence that a pullrequest may not necessary be needed anymore so now Updatecli can now close pull request that contain no changes.

This new behavior combined with an early design decision which is that Updatecli executes one pipeline at a time can lead to the following situation.

Updatecli loads two pipelines, pipeline A and pipeline B, targeting the same working branch.

  1. Pipeline A is executed
  • It detects that the working branch diverged
  • It recreate the working branch, push the changes
  • It detects an opened pullrequest with nothing to change anymore
  • It closes the pullrequest
  1. Pipeline B is executed
  • It detect some changes which need to be applied
  • It push the change and open a pullrequest as the previous one was closed by Pipeline A

If pipeline B is executed first then obviously there is not issue as Updatecli wouldn't close the pull request.

The major consequence of this workflow is the amount of notification send when pull requests are closed and reopened

Expected Behavior

Instead of running "action" per pipeline, I am considering running them once all pipelines have been executed.

Steps To Reproduce

No response

Environment

- OS: linux
- updatecli: 0.75.0

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working github_actions Pull requests that update Github_actions code
Projects
Archived in project
1 participant