From 1b241019faf4547422503fc26a7d51df5909359c Mon Sep 17 00:00:00 2001 From: eps1lon Date: Wed, 10 Jul 2024 13:38:35 +0200 Subject: [PATCH] Go back to using exact React versions in Pages Router latest RCs have considerably diverged from rc.0 --- packages/create-next-app/templates/index.ts | 4 ++-- packages/next/package.json | 4 ++-- run-tests.js | 2 +- test/e2e/next-test/first-time-setup-js/package.json | 4 ++-- test/e2e/next-test/first-time-setup-ts/package.json | 4 ++-- test/lib/next-modes/base.ts | 2 +- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/packages/create-next-app/templates/index.ts b/packages/create-next-app/templates/index.ts index 1d54f8ae0e63cf..90d23fdfecf89a 100644 --- a/packages/create-next-app/templates/index.ts +++ b/packages/create-next-app/templates/index.ts @@ -184,8 +184,8 @@ export const installTemplate = async ({ * Default dependencies. */ dependencies: { - react: "19.0.0-rc.0", - "react-dom": "19.0.0-rc.0", + react: "19.0.0-rc-a26e3f403e-20240611", + "react-dom": "19.0.0-rc-a26e3f403e-20240611", next: version, }, devDependencies: {}, diff --git a/packages/next/package.json b/packages/next/package.json index a5fa4bd51a7eee..dc9b9921aeb7a2 100644 --- a/packages/next/package.json +++ b/packages/next/package.json @@ -105,8 +105,8 @@ "@opentelemetry/api": "^1.1.0", "@playwright/test": "^1.41.2", "babel-plugin-react-compiler": "*", - "react": "19.0.0-rc.0", - "react-dom": "19.0.0-rc.0", + "react": "19.0.0-rc-a26e3f403e-20240611", + "react-dom": "19.0.0-rc-a26e3f403e-20240611", "sass": "^1.3.0" }, "peerDependenciesMeta": { diff --git a/run-tests.js b/run-tests.js index 6d675fa4c18abe..7fca4dedd06a68 100644 --- a/run-tests.js +++ b/run-tests.js @@ -415,7 +415,7 @@ ${ENDGROUP}`) // a starter Next.js install to re-use to speed up tests // to avoid having to run yarn each time console.log(`${GROUP}Creating Next.js install for isolated tests`) - const reactVersion = process.env.NEXT_TEST_REACT_VERSION || '19.0.0-rc.0' + const reactVersion = process.env.NEXT_TEST_REACT_VERSION || '19.0.0-rc-a26e3f403e-20240611' const { installDir, pkgPaths, tmpRepoDir } = await createNextInstall({ parentSpan: mockTrace(), dependencies: { diff --git a/test/e2e/next-test/first-time-setup-js/package.json b/test/e2e/next-test/first-time-setup-js/package.json index 52f5ddec3d6d31..18f7c878aaade3 100644 --- a/test/e2e/next-test/first-time-setup-js/package.json +++ b/test/e2e/next-test/first-time-setup-js/package.json @@ -8,7 +8,7 @@ }, "dependencies": { "next": "canary", - "react": "19.0.0-rc.0", - "react-dom": "19.0.0-rc.0" + "react": "19.0.0-rc-a26e3f403e-20240611", + "react-dom": "19.0.0-rc-a26e3f403e-20240611" } } diff --git a/test/e2e/next-test/first-time-setup-ts/package.json b/test/e2e/next-test/first-time-setup-ts/package.json index b63b0017400507..7539691bb77100 100644 --- a/test/e2e/next-test/first-time-setup-ts/package.json +++ b/test/e2e/next-test/first-time-setup-ts/package.json @@ -8,8 +8,8 @@ }, "dependencies": { "next": "canary", - "react": "19.0.0-rc.0", - "react-dom": "19.0.0-rc.0" + "react": "19.0.0-rc-a26e3f403e-20240611", + "react-dom": "19.0.0-rc-a26e3f403e-20240611" }, "devDependencies": { "@types/react": "^18", diff --git a/test/lib/next-modes/base.ts b/test/lib/next-modes/base.ts index b767dfd628fe17..f9f52d38f865a2 100644 --- a/test/lib/next-modes/base.ts +++ b/test/lib/next-modes/base.ts @@ -161,7 +161,7 @@ export class NextInstance { ) const reactVersion = - process.env.NEXT_TEST_REACT_VERSION || '19.0.0-rc.0' + process.env.NEXT_TEST_REACT_VERSION || '19.0.0-rc-a26e3f403e-20240611' const finalDependencies = { react: reactVersion, 'react-dom': reactVersion,