fix: resolve directory correctly when fs.cachedChecks: true (#15983)

Author: sapphi-red

packages/vite/src/node/fsUtils.ts

@@ -189,6 +189,10 @@ export function createCachedFsUtils(config: ResolvedConfig): FsUtils {
   function getDirentCacheFromPath(
     normalizedFile: string,
   ): DirentCache | false | undefined {
+    // path.posix.normalize may return a path either with / or without /
+    if (normalizedFile[normalizedFile.length - 1] === '/') {
+      normalizedFile = normalizedFile.slice(0, -1)
+    }
     if (normalizedFile === root) {
       return rootCache
     }

playground/resolve/__tests__/resolve.spec.ts

@@ -215,6 +215,10 @@ test('Resolve doesnt interrupt page request with trailing query and .css', async
   expect(await page.textContent('h1')).toBe('Resolve')
 })
 
+test('resolve non-normalized absolute path', async () => {
+  expect(await page.textContent('.non-normalized')).toMatch('[success]')
+})
+
 test.runIf(!isWindows)(
   'Resolve doesnt interrupt page request that clashes with local project package.json',
   async () => {

playground/resolve/index.html

@@ -167,6 +167,9 @@ <h2>resolve.conditions</h2>
 <h2>resolve package that contains # in path</h2>
 <p class="path-contains-sharp-symbol"></p>
 
+<h2>resolve non normalized absolute path</h2>
+<p class="non-normalized"></p>
+
 <script type="module">
   import '@generated-content-virtual-file'
   function text(selector, text) {
@@ -384,6 +387,9 @@ <h2>resolve package that contains # in path</h2>
     '.path-contains-sharp-symbol',
     `[success] ${contains.call('#', '#')} ${last.call('#')}`,
   )
+
+  import nonNormalizedAbsolute from '@non-normalized'
+  text('.non-normalized', nonNormalizedAbsolute)
 </script>
 
 <style>

playground/resolve/non-normalized.js

@@ -0,0 +1 @@
+export default '[success] non normalized absolute path'

playground/resolve/vite.config.js

@@ -99,6 +99,13 @@ export default defineConfig({
         }
       },
     },
+    {
+      name: 'resolve to non normalized absolute',
+      async resolveId(id) {
+        if (id !== '@non-normalized') return
+        return this.resolve(__dirname + '//non-normalized')
+      },
+    },
   ],
   optimizeDeps: {
     include: [