Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[idea] Render a visual preview of the snippet #23

Open
oliviertassinari opened this issue Oct 10, 2020 · 7 comments
Open

[idea] Render a visual preview of the snippet #23

oliviertassinari opened this issue Oct 10, 2020 · 7 comments

Comments

@oliviertassinari
Copy link
Contributor

For instance:

Capture d’écran 2020-10-10 à 16 40 43

Capture d’écran 2020-10-10 à 16 42 24

@oliviertassinari oliviertassinari changed the title [Idea] Render a visual preview of the snippet [idea] Render a visual preview of the snippet Oct 10, 2020
@jedwards1211
Copy link
Contributor

Yeah that would be cool. I'm pretty swamped with other stuff at the moment, but I'd like to implement this eventually!

@oliviertassinari
Copy link
Contributor Author

oliviertassinari commented Oct 11, 2020

There is a related issue opened for icons: mui/material-ui#19697.

@arpitBhalla
Copy link

Hey @jedwards1211 I can work on it, if you say

completion.documentation = new vscode.MarkdownString(description)

@jedwards1211
Copy link
Contributor

@oliviertassinari since a lot of the snippets allow you to select the variant it seems like the previews should show all variants, right?
There should probably be a way for the snippet to declare other defaults to use for previews...

@jedwards1211
Copy link
Contributor

jedwards1211 commented Sep 29, 2021

I've been slowly working on this. I finally got all the snippets migrated to a JSX-based declaration system I engineered, so that I'm just a few steps away from actually rendering visual previews.

@oliviertassinari
Copy link
Contributor Author

Should we migrate this issue to https://github.com/vscodeshift/mui-snippets? If I understand it correctly, this repository is meant to be legacy.

@jedwards1211
Copy link
Contributor

Yeah that's right. Since y'all were renaming the package scope from @material-ui to @mui I thought mui-snippets would be a good name for the new repo. The fact that MUI was intended to encompass more than Material UI totally went over my head.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants